Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles

From: Icenowy Zheng
Date: Tue Jul 12 2022 - 01:54:21 EST


在 2022-07-01星期五的 23:24 -0500,Samuel Holland写道:
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences
> in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.

Should this kind of assignment be described in DT instead?

>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> ---
>
>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10
> ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
>    compatible:
>      enum:
>        - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-a33-mbus
> +      - allwinner,sun8i-a50-mbus
> +      - allwinner,sun8i-a83t-mbus
>        - allwinner,sun8i-h3-mbus
>        - allwinner,sun8i-r40-mbus
> +      - allwinner,sun8i-v3s-mbus
> +      - allwinner,sun8i-v536-mbus
> +      - allwinner,sun20i-d1-mbus
>        - allwinner,sun50i-a64-mbus
> +      - allwinner,sun50i-a100-mbus
>        - allwinner,sun50i-h5-mbus
> +      - allwinner,sun50i-h6-mbus
> +      - allwinner,sun50i-h616-mbus
> +      - allwinner,sun50i-r329-mbus
>  
>    reg:
>      minItems: 1