Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src

From: Robert Marko
Date: Mon Jul 11 2022 - 17:14:57 EST


On Mon, 11 Jul 2022 at 23:10, Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
>
> Quoting Robert Marko (2022-05-15 14:00:47)
> > diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> > index 3204d550ff76..42d185fe19c8 100644
> > --- a/drivers/clk/qcom/gcc-ipq8074.c
> > +++ b/drivers/clk/qcom/gcc-ipq8074.c
> > @@ -663,6 +663,7 @@ static struct clk_branch gcc_sleep_clk_src = {
> > },
> > .num_parents = 1,
> > .ops = &clk_branch2_ops,
> > + .flags = CLK_IS_CRITICAL,
> > },
>
> Why not just remove the clk from the driver? Is anything using it?

Hi Stephen, USB sleep clocks are derived from it so it cant be dropped.

Regards,
Robert