Re: [PATCH v3 2/2] pinctrl: ocelot: Fix pincfg

[Horatiu Vultur]

The 07/11/2022 21:51, Andy Shevchenko wrote:
> 
> On Mon, Jul 11, 2022 at 9:17 PM Horatiu Vultur
> <horatiu.vultur@xxxxxxxxxxxxx> wrote:
> >
> > The blamed commit changed to use regmaps instead of __iomem. But it
> > didn't update the register offsets to be at word offset, so it uses byte
> > offset.
> > Another issue with the same commit is that it has a limit of 32 registers
> > which is incorrect. The sparx5 has 64 while lan966x has 77.
> 
> ...
> 
> > -static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
> > +static struct regmap *ocelot_pinctrl_create_pincfg(struct ocelot_pinctrl *info,
> > +                                                  struct platform_device *pdev)
> 
> const?
> 
> And I would leave pdev to be the first parameter, if there are no
> other functions that have them like this.

I will do that in the next version.
Just for my understanding/knowledge why is this desire to have const or
to keep the const?

> 
> --
> With Best Regards,
> Andy Shevchenko

-- 
/Horatiu