Re: [PATCH -V2 1/7] migrate: fix syscall move_pages() return value for failure

[Oscar Salvador]

On Mon, Jul 11, 2022 at 04:49:42PM +0800, Huang Ying wrote:
>  	return store_status(status, start, node, i - start);
> @@ -1768,8 +1768,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
>  
>  		err = move_pages_and_store_status(mm, current_node, &pagelist,
>  				status, start, i, nr_pages);
> -		if (err)
> +		if (err) {
> +			/* We have stored status of page i */

IMHO, "We have accounted for page i" gives a more clear statement.

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>

> +			if (err > 0)
> +				err--;
>  			goto out;
> +		}
>  		current_node = NUMA_NO_NODE;
>  	}
>  out_flush:
> -- 
> 2.30.2
> 
> 

-- 
Oscar Salvador
SUSE Labs