Re: [PATCH] arm64: dts: mediatek: Add missing xHCI clocks for mt8192 and mt8195

From: AngeloGioacchino Del Regno
Date: Mon Jul 11 2022 - 06:15:32 EST


Il 08/07/22 21:43, Nícolas F. R. A. Prado ha scritto:
The MediaTek xHCI dt-binding expects a specific order for the clocks,
but the mt8192 and mt8195 devicetrees were skipping some of the middle
clocks. These clocks are wired to the controller hardware but aren't
controllable.

Add the missing clocks as handles to fixed clocks, so that the clock
order is respected and the dtbs_check warnings are gone.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

---
A previous attempt to solve this also made all clocks required and
updated all MediaTek DTs using the xhci binding [1].

To avoid the DT change noise, the binding change is now being reverted
[2] and only mt8192 and mt8195 DTs are updated in this commit to get rid
of the warnings.

[1] https://lore.kernel.org/all/20220623193702.817996-4-nfraprado@xxxxxxxxxxxxx/
[2] https://lore.kernel.org/all/20220708192605.43351-1-nfraprado@xxxxxxxxxxxxx

arch/arm64/boot/dts/mediatek/mt8192.dtsi | 9 ++++++---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 18 ++++++++++++++----
2 files changed, 20 insertions(+), 7 deletions(-)