Re: [PATCH v2 2/3] pinctrl: sunxi: add support for R329 CPUX pin controller

[Andy Shevchenko]

On Sun, Jul 10, 2022 at 10:22 AM Icenowy Zheng <uwu@xxxxxxxxxx> wrote:
>
> Allwinner R329 SoC has two pin controllers similar to ones on previous
> SoCs, one in CPUX power domain and another in CPUS.
>
> This patch adds support for the CPUX domain pin controller.

...

> +#include <linux/module.h>
> +#include <linux/platform_device.h>

> +#include <linux/of.h>
> +#include <linux/of_device.h>

No use of these.

> +#include <linux/pinctrl/pinctrl.h>

Missed headers:
mod_devicetable.h

> +#include "pinctrl-sunxi.h"

-- 
With Best Regards,
Andy Shevchenko