Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add key mappings

[Hans de Goede]

Hi,

On 7/10/22 13:37, Misaka19465 wrote:
> On laptops like ASUS TUF Gaming A15, which have hotkeys to start Armoury
> Crate or AURA Sync, these hotkeys are unavailable. This patch add
> mappings for them.
> 
> Signed-off-by: Misaka19465 <misaka19465@xxxxxxxxxxxxx>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/asus-nb-wmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 57a07db65..478dd300b 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -522,6 +522,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
>  	{ KE_KEY, 0x32, { KEY_MUTE } },
>  	{ KE_KEY, 0x35, { KEY_SCREENLOCK } },
> +	{ KE_KEY, 0x38, { KEY_PROG3 } }, /* Armoury Crate */
>  	{ KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
>  	{ KE_KEY, 0x41, { KEY_NEXTSONG } },
>  	{ KE_KEY, 0x43, { KEY_STOPCD } }, /* Stop/Eject */
> @@ -574,6 +575,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0xA5, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV + HDMI */
>  	{ KE_KEY, 0xA6, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV + HDMI */
>  	{ KE_KEY, 0xA7, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV + HDMI */
> +	{ KE_KEY, 0xB3, { KEY_PROG4 } }, /* AURA */
>  	{ KE_KEY, 0xB5, { KEY_CALC } },
>  	{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
>  	{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },