Re: [PATCH v1 1/7] platform/x86: serial-multi-instantiate: return -ENOENT when no resources found

From: Hans de Goede
Date: Sat Jul 09 2022 - 05:46:03 EST


Hi Andy,

On 7/9/22 02:06, Andy Shevchenko wrote:
> Distinguish the case when device is present, but there are no resources.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

IMHO it would have been better to squash this together with patch 2/7,
but think patch 2/7 should be dropped, so this one should be dropped
to IMHO.

Regards,

Hans


> ---
> drivers/platform/x86/serial-multi-instantiate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
> index 1e8063b7c169..97db23243018 100644
> --- a/drivers/platform/x86/serial-multi-instantiate.c
> +++ b/drivers/platform/x86/serial-multi-instantiate.c
> @@ -100,7 +100,7 @@ static int smi_spi_probe(struct platform_device *pdev, struct acpi_device *adev,
> if (ret < 0)
> return ret;
> else if (!ret)
> - return -ENODEV;
> + return -ENOENT;
>
> count = ret;
>
> @@ -184,7 +184,7 @@ static int smi_i2c_probe(struct platform_device *pdev, struct acpi_device *adev,
> if (ret < 0)
> return ret;
> else if (!ret)
> - return -ENODEV;
> + return -ENOENT;
>
> count = ret;
>