[ammarfaizi2-block:stable/linux-stable-rc/queue/5.15 152/161] drivers/gpu/drm/msm/dp/dp_drm.c:232:9: error: implicit declaration of function 'drm_bridge_add'; did you mean 'drm_bridge_detach'?

From: kernel test robot
Date: Sat Jul 09 2022 - 00:27:29 EST


tree: https://github.com/ammarfaizi2/linux-block stable/linux-stable-rc/queue/5.15
head: ab88938c957f2e2edc60e19ab6df7830fc1c6914
commit: 42a454ce9e575e4f0612400ba97fbc58dff4ed82 [152/161] drm/msm: properly add and remove internal bridges
config: arm-defconfig (https://download.01.org/0day-ci/archive/20220709/202207091217.fY2v8aau-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/42a454ce9e575e4f0612400ba97fbc58dff4ed82
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block stable/linux-stable-rc/queue/5.15
git checkout 42a454ce9e575e4f0612400ba97fbc58dff4ed82
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/gpu/drm/msm/dp/dp_drm.c:16:27: error: field 'bridge' has incomplete type
16 | struct drm_bridge bridge;
| ^~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c: In function 'dp_bridge_mode_set':
drivers/gpu/drm/msm/dp/dp_drm.c:181:55: error: invalid use of undefined type 'struct drm_bridge'
181 | msm_dp_display_mode_set(dp_display, drm_bridge->encoder, mode, adjusted_mode);
| ^~
drivers/gpu/drm/msm/dp/dp_drm.c: In function 'dp_bridge_enable':
drivers/gpu/drm/msm/dp/dp_drm.c:189:53: error: invalid use of undefined type 'struct drm_bridge'
189 | msm_dp_display_enable(dp_display, drm_bridge->encoder);
| ^~
drivers/gpu/drm/msm/dp/dp_drm.c: In function 'dp_bridge_disable':
drivers/gpu/drm/msm/dp/dp_drm.c:197:58: error: invalid use of undefined type 'struct drm_bridge'
197 | msm_dp_display_pre_disable(dp_display, drm_bridge->encoder);
| ^~
drivers/gpu/drm/msm/dp/dp_drm.c: In function 'dp_bridge_post_disable':
drivers/gpu/drm/msm/dp/dp_drm.c:205:54: error: invalid use of undefined type 'struct drm_bridge'
205 | msm_dp_display_disable(dp_display, drm_bridge->encoder);
| ^~
drivers/gpu/drm/msm/dp/dp_drm.c: At top level:
drivers/gpu/drm/msm/dp/dp_drm.c:208:21: error: variable 'dp_bridge_ops' has initializer but incomplete type
208 | static const struct drm_bridge_funcs dp_bridge_ops = {
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:209:10: error: 'const struct drm_bridge_funcs' has no member named 'enable'
209 | .enable = dp_bridge_enable,
| ^~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:209:25: warning: excess elements in struct initializer
209 | .enable = dp_bridge_enable,
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:209:25: note: (near initialization for 'dp_bridge_ops')
drivers/gpu/drm/msm/dp/dp_drm.c:210:10: error: 'const struct drm_bridge_funcs' has no member named 'disable'
210 | .disable = dp_bridge_disable,
| ^~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:210:25: warning: excess elements in struct initializer
210 | .disable = dp_bridge_disable,
| ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:210:25: note: (near initialization for 'dp_bridge_ops')
drivers/gpu/drm/msm/dp/dp_drm.c:211:10: error: 'const struct drm_bridge_funcs' has no member named 'post_disable'
211 | .post_disable = dp_bridge_post_disable,
| ^~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:211:25: warning: excess elements in struct initializer
211 | .post_disable = dp_bridge_post_disable,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:211:25: note: (near initialization for 'dp_bridge_ops')
drivers/gpu/drm/msm/dp/dp_drm.c:212:10: error: 'const struct drm_bridge_funcs' has no member named 'mode_set'
212 | .mode_set = dp_bridge_mode_set,
| ^~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:212:25: warning: excess elements in struct initializer
212 | .mode_set = dp_bridge_mode_set,
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:212:25: note: (near initialization for 'dp_bridge_ops')
drivers/gpu/drm/msm/dp/dp_drm.c: In function 'msm_dp_bridge_init':
drivers/gpu/drm/msm/dp/dp_drm.c:229:15: error: invalid use of undefined type 'struct drm_bridge'
229 | bridge->funcs = &dp_bridge_ops;
| ^~
drivers/gpu/drm/msm/dp/dp_drm.c:230:15: error: invalid use of undefined type 'struct drm_bridge'
230 | bridge->encoder = encoder;
| ^~
>> drivers/gpu/drm/msm/dp/dp_drm.c:232:9: error: implicit declaration of function 'drm_bridge_add'; did you mean 'drm_bridge_detach'? [-Werror=implicit-function-declaration]
232 | drm_bridge_add(bridge);
| ^~~~~~~~~~~~~~
| drm_bridge_detach
drivers/gpu/drm/msm/dp/dp_drm.c:234:14: error: implicit declaration of function 'drm_bridge_attach'; did you mean 'drm_bridge_detach'? [-Werror=implicit-function-declaration]
234 | rc = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
| ^~~~~~~~~~~~~~~~~
| drm_bridge_detach
drivers/gpu/drm/msm/dp/dp_drm.c:234:55: error: 'DRM_BRIDGE_ATTACH_NO_CONNECTOR' undeclared (first use in this function)
234 | rc = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_drm.c:234:55: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu/drm/msm/dp/dp_drm.c:237:17: error: implicit declaration of function 'drm_bridge_remove'; did you mean 'drm_bridge_detach'? [-Werror=implicit-function-declaration]
237 | drm_bridge_remove(bridge);
| ^~~~~~~~~~~~~~~~~
| drm_bridge_detach
drivers/gpu/drm/msm/dp/dp_drm.c: At top level:
drivers/gpu/drm/msm/dp/dp_drm.c:208:38: error: storage size of 'dp_bridge_ops' isn't known
208 | static const struct drm_bridge_funcs dp_bridge_ops = {
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +232 drivers/gpu/drm/msm/dp/dp_drm.c

207
208 static const struct drm_bridge_funcs dp_bridge_ops = {
209 .enable = dp_bridge_enable,
210 .disable = dp_bridge_disable,
211 .post_disable = dp_bridge_post_disable,
> 212 .mode_set = dp_bridge_mode_set,
213 };
214
215 struct drm_bridge *msm_dp_bridge_init(struct msm_dp *dp_display, struct drm_device *dev,
216 struct drm_encoder *encoder)
217 {
218 int rc;
219 struct msm_dp_bridge *dp_bridge;
220 struct drm_bridge *bridge;
221
222 dp_bridge = devm_kzalloc(dev->dev, sizeof(*dp_bridge), GFP_KERNEL);
223 if (!dp_bridge)
224 return ERR_PTR(-ENOMEM);
225
226 dp_bridge->dp_display = dp_display;
227
228 bridge = &dp_bridge->bridge;
229 bridge->funcs = &dp_bridge_ops;
230 bridge->encoder = encoder;
231
> 232 drm_bridge_add(bridge);
233
> 234 rc = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
235 if (rc) {
236 DRM_ERROR("failed to attach bridge, rc=%d\n", rc);
> 237 drm_bridge_remove(bridge);

--
0-DAY CI Kernel Test Service
https://01.org/lkp