Re: [pdx86-platform-drivers-x86:review-hans 66/68] drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume'

[Kammela, Gayatri]

On 7/8/2022 7:44 AM, Hans de Goede wrote:

> Hi,
>
> On 7/4/22 12:51, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
> > head:   530ef2a6e81c74c19f918713e519e85652e53a83
> > commit: 1039bb2698ab299a1fc30a4fc2df237867c089e0 [66/68] platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT
> > config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220704/202207041814.S03OvoFK-lkp@xxxxxxxxx/config)
> > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> > reproduce (this is a W=1 build):
> >          # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=1039bb2698ab299a1fc30a4fc2df237867c089e0
> >          git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
> >          git fetch --no-tags pdx86-platform-drivers-x86 review-hans
> >          git checkout 1039bb2698ab299a1fc30a4fc2df237867c089e0
> >          # save the config file
> >          mkdir build_dir && cp config build_dir/.config
> >          make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/intel/
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All warnings (new ones prefixed by >>):
> >
> > > > drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' [-Wmissing-prototypes]
> >       475 | void intel_vsec_pci_resume(struct pci_dev *pdev)
> >           |      ^~~~~~~~~~~~~~~~~~~~~
> >
> >
> > vim +/intel_vsec_pci_resume +475 drivers/platform/x86/intel/vsec.c
> >
> >     474	
> >   > 475	void intel_vsec_pci_resume(struct pci_dev *pdev)
> >     476	{
> >     477		dev_info(&pdev->dev, "Done resuming PCI device\n");
> >     478	}
> >     479	
>
> I've squashed a patch marking intel_vsec_pci_resume() as static into my
> review-hans branch.
Thank you Hans!
> Regards,
>
> Hans