Re: [PATCH V2 00/13] OPP: Add support for multiple clocks*

From: Viresh Kumar
Date: Fri Jul 08 2022 - 04:12:42 EST


On 08-07-22, 10:26, Dmitry Osipenko wrote:
> On 7/8/22 10:19, Viresh Kumar wrote:
> > On 07-07-22, 22:43, Dmitry Osipenko wrote:
> >> This patch breaks Tegra again, please take a look:
> >
> > Damn, not again :(
> >
> >> OPP: Remove dev{m}_pm_opp_of_add_table_noclk()
> >
> > Why did you mention this patch ? This just removed an unused API,
> > Tegra should have broke because of something else, isn't it ?
>
> This patch is the cause.

I was tracking the crash too closely it seems. :(

> I see that previously dev_pm_opp_set_config() had "_add_opp_table(dev,
> false)", now it's "_add_opp_table(dev, true)".

That's definitely a mistake, I still don't understand though how it
can lead to the crash we got.

I have fixed this in my tree now, can you check again please.

--
viresh