Re: [PATCH bpf-next 2/3] ftrace: Keep address offset in ftrace_lookup_symbols

From: Jiri Olsa
Date: Mon May 30 2022 - 03:31:18 EST


On Mon, May 30, 2022 at 05:37:49AM +0000, Song Liu wrote:
>
>
> > On May 27, 2022, at 1:56 PM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> >
> > We want to store the resolved address on the same index as
> > the symbol string, because that's the user (bpf kprobe link)
> > code assumption.
> >
> > Also making sure we don't store duplicates that might be
> > present in kallsyms.
> >
> > Fixes: bed0d9a50dac ("ftrace: Add ftrace_lookup_symbols function")
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>
> Acked-by: Song Liu <songliubraving@xxxxxx>
>
> BTW, I guess this set should apply to bpf tree?
>

ah right, I checked and it still applies on bpf/master,
please let me know if I need to resend without 'bpf-next'

thanks,
jirka