Re: [PATCH bpf-next 2/3] ftrace: Keep address offset in ftrace_lookup_symbols

From: Song Liu
Date: Mon May 30 2022 - 01:37:59 EST




> On May 27, 2022, at 1:56 PM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> We want to store the resolved address on the same index as
> the symbol string, because that's the user (bpf kprobe link)
> code assumption.
>
> Also making sure we don't store duplicates that might be
> present in kallsyms.
>
> Fixes: bed0d9a50dac ("ftrace: Add ftrace_lookup_symbols function")
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Acked-by: Song Liu <songliubraving@xxxxxx>

BTW, I guess this set should apply to bpf tree?