Re: mainline build failure due to 8bdc2a190105 ("crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE")

From: Jason A. Donenfeld
Date: Sat May 28 2022 - 06:47:36 EST


Hi Sudip,

On Sat, May 28, 2022 at 12:43 PM Sudip Mukherjee
<sudipm.mukherjee@xxxxxxxxx> wrote:
>
> Hi All,
>
> The latest mainline kernel branch fails to build for:
>
> arm: imx_v6_v7_defconfig and multi_v7_defconfig
> mips: decstation_64_defconfig, decstation_defconfig, decstation_r4k_defconfig
>
> with errors like:
>
> In file included from crypto/chacha20poly1305.c:13:
> ./include/crypto/poly1305.h:56:46: error: 'CONFIG_CRYPTO_LIB_POLY1305_RSIZE' undeclared here (not in a function); did you mean 'CONFIG_CRYPTO_POLY1305_MODULE'?
> 56 | struct poly1305_key opaque_r[CONFIG_CRYPTO_LIB_POLY1305_RSIZE];
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
> git bisect pointed to 8bdc2a190105 ("crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE")
>
> I have checked .config to confirm that it contains:
>
> CONFIG_CRYPTO_CHACHA20POLY1305=m
> # CONFIG_CRYPTO_LIB_POLY1305 is not set
>
> so, CONFIG_CRYPTO_LIB_POLY1305_RSIZE will not be defined as it now
> depends on CONFIG_CRYPTO_LIB_POLY1305.

Indeed. There's this v2:
https://lore.kernel.org/all/20220527201931.63955-1-Jason@xxxxxxxxx/

I'll send a v1/v2 interdiff shortly.

Jason