Re: [RFC PATCH 05/14] media: camss: csid: Add support for 8x74

[Robert Foss]

On Sun, 22 May 2022 at 18:28, Luca Weiss <luca@xxxxxxxxx> wrote:
>
> From: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
>
> CSID hardware module on 8x74 is similar to 8x16.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss-csid.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index f993f349b66b..6b5cd9a66ff6 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -570,7 +570,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
>         csid->camss = camss;
>         csid->id = id;
>
> -       if (camss->version == CAMSS_8x16) {
> +       if (camss->version == CAMSS_8x16 ||
> +               camss->version == CAMSS_8x74) {

CHECK: Alignment should match open parenthesis
#27: FILE: drivers/media/platform/qcom/camss/camss-csid.c:574:
+    if (camss->version == CAMSS_8x16 ||
+        camss->version == CAMSS_8x74) {


>                 csid->ops = &csid_ops_4_1;
>         } else if (camss->version == CAMSS_8x96 ||
>                    camss->version == CAMSS_660) {
> --
> 2.36.0
>

With that fixed:

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>