Re: [RFC PATCH 04/14] media: camss: video: Add support for 8x74

From: Robert Foss
Date: Thu May 26 2022 - 08:37:31 EST


On Sun, 22 May 2022 at 18:28, Luca Weiss <luca@xxxxxxxxx> wrote:
>
> From: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
>
> Video formats in 8x16 and 8x74 are similar.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> ---
> drivers/media/platform/qcom/camss/camss-video.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c
> index 307bb1dc4589..ca955808fd6d 100644
> --- a/drivers/media/platform/qcom/camss/camss-video.c
> +++ b/drivers/media/platform/qcom/camss/camss-video.c
> @@ -990,7 +990,8 @@ int msm_video_register(struct camss_video *video, struct v4l2_device *v4l2_dev,
>
> mutex_init(&video->lock);
>
> - if (video->camss->version == CAMSS_8x16) {
> + if (video->camss->version == CAMSS_8x16 ||
> + video->camss->version == CAMSS_8x74) {

#27: FILE: drivers/media/platform/qcom/camss/camss-video.c:994:
+ if (video->camss->version == CAMSS_8x16 ||
+ video->camss->version == CAMSS_8x74) {


> if (is_pix) {
> video->formats = formats_pix_8x16;
> video->nformats = ARRAY_SIZE(formats_pix_8x16);
> --
> 2.36.0
>

With that fixed:

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>