Re: [PATCH v4 2/3] dt-bindings: remoteproc: qcom: Convert SC7280 MSS bindings to YAML

[Sibi Sankar]

On 5/21/22 1:40 AM, Stephen Boyd wrote:
> Quoting Sibi Sankar (2022-05-20 11:46:58)
> > On 5/20/22 4:05 AM, Stephen Boyd wrote:
> > > Quoting Sibi Sankar (2022-05-19 09:47:04)
> > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml
> > > > new file mode 100644
> > > > index 000000000000..a936d84eefa6
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml
> > > > +        resets = <&aoss_reset AOSS_CC_MSS_RESTART>,
> > > > +                 <&pdc_reset PDC_MODEM_SYNC_RESET>;
> > > > +        reset-names = "mss_restart", "pdc_reset";
> > > > +
> > > > +        qcom,halt-regs = <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>;
> > > > +        qcom,ext-regs = <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>;
> > >
> > > Because it's two items I'd expect:
> > >
> > >        <&tcsr 0x10000 0x10004>, <&tcsr_mutex 0x26004 0x26008>;
> >
> > I guess both the ways work since the driver uses
> > of_parse_phandle_with_fixed_args.
>
> See commit 39bd2b6a3783 ("dt-bindings: Improve phandle-array schemas")
> for why the way you have it is not preferred.

Sure, I'll fix the dt up and update the example.

-Sibi

>