Re: [PATCH v2 4/7] perf jevents: Modify match field

From: Arnaldo Carvalho de Melo
Date: Mon May 23 2022 - 09:09:38 EST


Em Tue, May 17, 2022 at 02:35:14PM +0100, John Garry escreveu:
> On 11/05/2022 22:15, Ian Rogers wrote:
> > The match_field function looks for json values to append to the event
> > string. As the C code processes these in order the output order matches
> > that in the json dictionary. Python json readers read the entire
> > dictionary and lose the ordering. To make the python and C output
> > comparable make the C code first read the extra fields then append them
> > to the event in an order not determined by their order in the file.
> >
> > Modify the pmu-events test so that test expectations match the new
> > order.
> >
> > Signed-off-by: Ian Rogers<irogers@xxxxxxxxxx>
>
> Reviewed-by: John Garry <john.garry@xxxxxxxxxx>


Applied up to here, will take a closer look at 5-7

- Arnaldo