Re: [PATCH 1/5] kernfs: Remove reference counting for kernfs_open_node.

From: Tejun Heo
Date: Thu May 05 2022 - 15:47:12 EST


On Thu, Apr 28, 2022 at 03:54:27PM +1000, Imran Khan wrote:
> The decision to free kernfs_open_node object in kernfs_put_open_node can
> be taken based on whether kernfs_open_node->files list is empty or not. As
> far as kernfs_drain_open_files is concerned it can't overlap with
> kernfs_fops_open and hence can check for ->attr.open optimistically
> (if ->attr.open is NULL) or under kernfs_open_file_mutex (if it needs to
> traverse the ->files list.) Thus kernfs_drain_open_files can work w/o ref
> counting involved kernfs_open_node as well.
> So remove ->refcnt and modify the above mentioned users accordingly.
>
> Suggested by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Imran Khan <imran.f.khan@xxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun