Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg'

From: Sergey Shtylyov
Date: Thu Apr 14 2022 - 14:26:58 EST


On 4/14/22 12:32 PM, Geert Uytterhoeven wrote:

[...]
>>> Fix this issue by freeing the cpg when exiting the function in the
>>> error/normal path.
>>>
>>> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
>>> ---
>>> V1->V2: free both cpg&clks.
>>>
>>> drivers/clk/renesas/clk-r8a73a4.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> 2 patches with the same name won't do -- you always need to include the chip name
>> part of the file name in the subject (in this case r8a73a4).
>
> Oh, they were for multiple drivers?

I counted 3! :-)

> I hadn't even noticed , as Gmail collapsed them all into the same thread...

Hm, they weren't actually posted in the same thread...

> Gr{oetje,eeting}s,
>
> Geert
[...]

MBR, Sergey