Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg'

From: Geert Uytterhoeven
Date: Thu Apr 14 2022 - 05:33:15 EST


Hi Sergei,

On Thu, Apr 14, 2022 at 11:29 AM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote:
> On 4/13/22 11:19 AM, Haowen Bai wrote:
> > Fix this issue by freeing the cpg when exiting the function in the
> > error/normal path.
> >
> > Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> > ---
> > V1->V2: free both cpg&clks.
> >
> > drivers/clk/renesas/clk-r8a73a4.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
>
> 2 patches with the same name won't do -- you always need to include the chip name
> part of the file name in the subject (in this case r8a73a4).

Oh, they were for multiple drivers?
I hadn't even noticed , as Gmail collapsed them all into the same thread...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds