Re: [PATCH] netfilter: conditionally use ct and ctinfo

[Florian Westphal]

Tom Rix <trix@xxxxxxxxxx> wrote:
> 
> On 3/7/22 4:46 AM, Florian Westphal wrote:
> > trix@xxxxxxxxxx <trix@xxxxxxxxxx> wrote:
> > > From: Tom Rix <trix@xxxxxxxxxx>
> > > 
> > > The setting ct and ctinfo are controlled by
> > > CONF_NF_CONNTRACK.  So their use should also
> > > be controlled.
> > Any reason for this change?
> 
> Define and use are connected. Doing something to one without doing something
> to the other doesn't make sense.

We often rely on compiler to remove branches that always evaluate to
false, just like in this case.

> Could removing the CONF_NF_CONNTRACK be done for the define side ?

Doubt it.  Looking at git history it avoids build breakage.