Re: [PATCH] netfilter: conditionally use ct and ctinfo

[Tom Rix]

On 3/7/22 4:46 AM, Florian Westphal wrote:
> trix@xxxxxxxxxx <trix@xxxxxxxxxx> wrote:
> > From: Tom Rix <trix@xxxxxxxxxx>
> >
> > The setting ct and ctinfo are controlled by
> > CONF_NF_CONNTRACK.  So their use should also
> > be controlled.
> Any reason for this change?

Define and use are connected. Doing something to one without doing 
something to the other doesn't make sense.

Could removing the CONF_NF_CONNTRACK be done for the define side ?

Tom

> We try to avoid ifdef where possible, unless it avoids a compiler
> warning/build/linker issue.
>
> This doesn't change generated code for me (NF_CONNTRACK=n) either.