Re: [PATCH v6 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support

From: Heikki Krogerus
Date: Thu Mar 03 2022 - 08:13:46 EST


On Thu, Mar 03, 2022 at 10:47:57AM +0800, Xin Ji wrote:
> On Wed, Mar 02, 2022 at 02:03:18PM +0200, Heikki Krogerus wrote:
> > Hi,
> >
> > This does not apply on top of Greg's latest usb-next branch. You need
> > to rebase this. There are also a few more nitpicks below.
>
> Hi, I didn't found tcpci.h in include/linux/usb/

I'm asking you to create the file.

So create a separate patch where you move the register definitions and
command definitions from drivers/usb/typec/tcpm/tcpci.h to
include/linux/usb/tcpci.h

thanks,

--
heikki