Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

From: Joe Perches
Date: Thu Jan 20 2022 - 20:38:15 EST


On Wed, 2022-01-19 at 16:00 -0500, Steven Rostedt wrote:
> On Wed, 19 Jan 2022 21:25:08 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > > I say keep it one line!
> > >
> > > Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> >
> > I believe Sakari strongly follows the 80 rule, which means...
>
> Checkpatch says "100" I think we need to simply update the docs (the
> documentation always lags the code ;-)

checkpatch doesn't say anything normally, it's a stupid script.
It just mindlessly bleats a message when a line exceeds 100 chars...

Just fyi: I think it's nicer on a single line too.