Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

[Lucas De Marchi]

On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote:
> On Wed, 19 Jan 2022 11:18:59 +0200
> Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote:
> > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head,
> > >  	case 3:
> > >  		if (cond->grant_log != TOMOYO_GRANTLOG_AUTO)
> > >  			tomoyo_io_printf(head, " grant_log=%s",
> > > -					 tomoyo_yesno(cond->grant_log ==
> > > -						      TOMOYO_GRANTLOG_YES));
> > > +					 yesno(cond->grant_log == TOMOYO_GRANTLOG_YES));
> >
> > This would be better split on two lines.
>
> Really? Yuck!
>
> I thought the "max line size" guideline was going to grow to a 100, but I
> still see it as 80. But anyway...

Checking that: docs still say 80, but checkpatch was changed to warn
only on 100. Commit bdc48fa11e46 ("checkpatch/coding-style: deprecate
80-column warning") is clear why the discrepancy.

Lucas De Marchi

> 	cond->grant_log ==
> 	TOMOYO_GRANTLOG_YES
>
> is not readable at all. Not compared to
>
> 	cond->grant_log == TOMOYO_GRANTLOG_YES
>
> I say keep it one line!
>
> Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
>
> -- Steve
>
> > Then,
> >
> > Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>