Re: [PATCH] mm/pgtable: define pte_index so that preprocessor could recognize it

[Mike Rapoport]

Hi Christian,

On Tue, Jan 11, 2022 at 04:20:34PM +0100, Christian Dietrich wrote:
> Hello Mike!
> 
> Mike Rapoport <rppt@xxxxxxxxxx> [11. Januar 2022]:
> 
> > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> > index e24d2c992b11..d468efcf48f4 100644
> > --- a/include/linux/pgtable.h
> > +++ b/include/linux/pgtable.h
> > @@ -62,6 +62,7 @@ static inline unsigned long pte_index(unsigned long address)
> >  {
> >  	return (address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1);
> >  }
> > +#define pte_index pte_index
> 
> Wouldn't it make sense to remove the dead CPP blocks (#ifdef pte_index)
> from mm/memory.c? 

It does make sense to remove the dead code, but this cleanup does not need
stable backporting so it'll be a separate patch.

Care to send a patch? ;-)

> Or is there a case were pte_index is not defined for an architecture?

Nope, the fix in include/linux/pgtable.h covers MMU architectures and NOMMU
do not compile mm/memory.c anyway.

> chris
> -- 

-- 
Sincerely yours,
Mike.