Re: [PATCH] mm/pgtable: define pte_index so that preprocessor could recognize it

From: Christian Dietrich
Date: Tue Jan 11 2022 - 10:30:12 EST


Hello Mike!

Mike Rapoport <rppt@xxxxxxxxxx> [11. Januar 2022]:

> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index e24d2c992b11..d468efcf48f4 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -62,6 +62,7 @@ static inline unsigned long pte_index(unsigned long address)
> {
> return (address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1);
> }
> +#define pte_index pte_index

Wouldn't it make sense to remove the dead CPP blocks (#ifdef pte_index)
from mm/memory.c? Or is there a case were pte_index is not defined for
an architecture?

chris
--
Prof. Dr.-Ing. Christian Dietrich
Operating System Group (E-EXK4)
Technische Universität Hamburg
Am Schwarzenberg-Campus 3 (E), 4.092
21073 Hamburg

eMail: christian.dietrich@xxxxxxx
Tel: +49 40 42878 2188
WWW: https://osg.tuhh.de/