Re: [PATCH v8 04/40] x86/sev: Define the Linux specific guest termination reasons

From: Borislav Petkov
Date: Tue Dec 14 2021 - 17:22:16 EST


On Fri, Dec 10, 2021 at 09:42:56AM -0600, Brijesh Singh wrote:
> GHCB specification defines the reason code for reason set 0. The reason
> codes defined in the set 0 do not cover all possible causes for a guest
> to request termination.
>
> The reason set 1 to 255 is reserved for the vendor-specific codes.
> Reseve the reason set 1 for the Linux guest. Define an error codes for

Yah, your spellchecker is still broken:

Reseve the reason set 1 for the Linux guest. Define an error codes for
Unknown word [Reseve] in commit message, suggestions:
['Reeves', 'Reeve', 'Reserve', 'Res eve', 'Res-eve', 'Severe', 'Reverse', 'Sevres', 'Revers']

> reason set 1.

"... and use them in the Linux guest so that one can have meaningful
termination reasons and thus better guest failure diagnosis."

The *why* is very important.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette