Re: [PATCH v8 04/40] x86/sev: Define the Linux specific guest termination reasons

[Venu Busireddy]

On 2021-12-10 09:42:56 -0600, Brijesh Singh wrote:
> GHCB specification defines the reason code for reason set 0. The reason
> codes defined in the set 0 do not cover all possible causes for a guest
> to request termination.
> 
> The reason set 1 to 255 is reserved for the vendor-specific codes.

s/set 1 to 255 is/sets 1 to 255 are/

> Reseve the reason set 1 for the Linux guest. Define an error codes for

s/Define an/Define the/

> reason set 1.
> 
> While at it, change the sev_es_terminate() to accept the reason set
> parameter.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>

With that...

Reviewed-by: Venu Busireddy <venu.busireddy@xxxxxxxxxx>

> ---
>  arch/x86/boot/compressed/sev.c    |  6 +++---
>  arch/x86/include/asm/sev-common.h |  8 ++++++++
>  arch/x86/kernel/sev-shared.c      | 11 ++++-------
>  arch/x86/kernel/sev.c             |  4 ++--
>  4 files changed, 17 insertions(+), 12 deletions(-)