Re: [PATCH] pinctrl: intel: Assume 0 by default for PNP UID

From: Andy Shevchenko
Date: Tue Dec 07 2021 - 05:35:15 EST


On Tue, Dec 07, 2021 at 11:48:23AM +0800, Kai-Heng Feng wrote:
> On Sat, Dec 4, 2021 at 8:49 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Saturday, December 4, 2021, Kai-Heng Feng
> > <kai.heng.feng@xxxxxxxxxxxxx> wrote:
> > >
> > > There's an EHL board that the DSDT doesn't have _UID for pinctrl device,
> > > and that causes a NULL pointer dereference in strcmp().
> > >
> > > So in the absence of _UID, assume it's 0 by default to avoid the issue
> > > and get a pinmap.
> >
> > Do you have updated firmware?
>
> Customer confirmed new code drop from Intel does have _UID defined.
> So I guess this patch is not needed anymore?

It is not, this is the idea, thanks for confirming!

--
With Best Regards,
Andy Shevchenko