Re: [PATCH] PCI: imx: do not remap invalid res

From: Rob Herring
Date: Wed Dec 01 2021 - 21:42:12 EST


On Wed, Dec 1, 2021 at 6:48 PM Hongxing Zhu <hongxing.zhu@xxxxxxx> wrote:
>
>
> > -----Original Message-----
> > From: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> > Sent: Thursday, December 2, 2021 6:07 AM
> > To: Jingoo Han <jingoohan1@xxxxxxxxx>; Gustavo Pimentel
> > <gustavo.pimentel@xxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
> > Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>; Krzysztof Wilczyński
> > <kw@xxxxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>;
> > linux-pci@xxxxxxxxxxxxxxx
> > Cc: open list <linux-kernel@xxxxxxxxxxxxxxx>; Hongxing Zhu
> > <hongxing.zhu@xxxxxxx>
> > Subject: Re: [PATCH] PCI: imx: do not remap invalid res

Please fix your quoting style with all the headers (hint: don't use
Outlook). It's base64 encoded too which isn't ideal for maillists, but
somewhat tolerated nowadays.

> >
> > On Mon, Nov 1, 2021 at 11:03 AM Tim Harvey <tharvey@xxxxxxxxxxxxx>
> > wrote:
> > >
> > > On imx6 and perhaps others when pcie probes you get a:
> > > imx6q-pcie 33800000.pcie: invalid resource
> > >
> > > This occurs because the atu is not specified in the DT and as such it
> > > should not be remapped.
> > >
> > > Cc: Richard Zhu <hongxing.zhu@xxxxxxx>
> > > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> [Richard Zhu] Please merge Rob's commit log changes.

The maintainer tools do that automatically.

> Then, Acked-by: Richard Zhu <hongxing.zhu@xxxxxxx>

But probably not when you prefix your tag with 'Then, '... :(

Rob