RE: [PATCH] PCI: imx: do not remap invalid res

[Hongxing Zhu]

> -----Original Message-----
> From: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> Sent: Thursday, December 2, 2021 6:07 AM
> To: Jingoo Han <jingoohan1@xxxxxxxxx>; Gustavo Pimentel
> <gustavo.pimentel@xxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
> Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>; Krzysztof Wilczyński
> <kw@xxxxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>;
> linux-pci@xxxxxxxxxxxxxxx
> Cc: open list <linux-kernel@xxxxxxxxxxxxxxx>; Hongxing Zhu
> <hongxing.zhu@xxxxxxx>
> Subject: Re: [PATCH] PCI: imx: do not remap invalid res
> 
> On Mon, Nov 1, 2021 at 11:03 AM Tim Harvey <tharvey@xxxxxxxxxxxxx>
> wrote:
> >
> > On imx6 and perhaps others when pcie probes you get a:
> > imx6q-pcie 33800000.pcie: invalid resource
> >
> > This occurs because the atu is not specified in the DT and as such it
> > should not be remapped.
> >
> > Cc: Richard Zhu <hongxing.zhu@xxxxxxx>
> > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
[Richard Zhu] Please merge Rob's commit log changes.
Then, Acked-by: Richard Zhu <hongxing.zhu@xxxxxxx>

Best Regards
Richard Zhu
> > ---
> >  drivers/pci/controller/dwc/pcie-designware.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c
> > b/drivers/pci/controller/dwc/pcie-designware.c
> > index a945f0c0e73d..3254f60d1713 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -671,10 +671,11 @@ void dw_pcie_iatu_detect(struct dw_pcie
> *pci)
> >                 if (!pci->atu_base) {
> >                         struct resource *res =
> >
> platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu");
> > -                       if (res)
> > +                       if (res) {
> >                                 pci->atu_size =
> resource_size(res);
> > -                       pci->atu_base =
> devm_ioremap_resource(dev, res);
> > -                       if (IS_ERR(pci->atu_base))
> > +                               pci->atu_base =
> devm_ioremap_resource(dev, res);
> > +                       }
> > +                       if (!pci->atu_base ||
> IS_ERR(pci->atu_base))
> >                                 pci->atu_base = pci->dbi_base
> + DEFAULT_DBI_ATU_OFFSET;
> >                 }
> >
> > --
> > 2.17.1
> >
> 
> ping - any feedback on this?
> 
> Best regards,
> 
> Tim