Re: [PATCH] Revert "mark pstore-blk as broken"

[Geert Uytterhoeven]

On Thu, Nov 18, 2021 at 7:29 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Tue, Nov 16, 2021 at 05:23:44PM -0700, Jens Axboe wrote:
> > On Tue, 16 Nov 2021 10:15:59 -0800, Kees Cook wrote:
> > > This reverts commit d07f3b081ee632268786601f55e1334d1f68b997.
> > >
> > > pstore-blk was fixed to avoid the unwanted APIs in commit 7bb9557b48fc
> > > ("pstore/blk: Use the normal block device I/O path"), which landed in
> > > the same release as the commit adding BROKEN.
> > >
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] Revert "mark pstore-blk as broken"
> >       commit: d1faacbf67b1944f0e0c618dc581d929263f6fe9
>
> Thanks! I realize now what Geert meant in an earlier thread that I
> actually can't split this change from a warning fix that was living in
> the pstore tree (and was masked by the now removed BROKEN). Can you take
> this patch as well? I've removed it from my tree now...
>
> https://lore.kernel.org/lkml/20211118182621.1280983-1-keescook@xxxxxxxxxxxx/

Which is now a build error instead of a warning in Linus' tree.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds