Re: [PATCH 3/4] KVM: x86/pmu: Reuse find_perf_hw_id() and drop find_fixed_event()
From: Paolo Bonzini
Date: Fri Nov 19 2021 - 05:29:47 EST
On 11/19/21 08:16, Like Xu wrote:
It's proposed to get [V2] merged and continue to review the fixes from
[1] seamlessly,
and then further unify all fixed/gp stuff including
intel_find_fixed_event() as a follow up.
I agree and I'll review it soon. Though, why not add the
+ && (pmc_is_fixed(pmc) ||
+ pmu->available_event_types & (1 << i)))
version in v2 of this patch? :)
Paolo
[1] https://lore.kernel.org/kvm/20211112095139.21775-1-likexu@xxxxxxxxxxx/
[V2] https://lore.kernel.org/kvm/20211119064856.77948-1-likexu@xxxxxxxxxxx/