Re: [PATCH] scripts: make some scripts executable

[Greg KH]

On Wed, Jul 28, 2021 at 12:39:24AM +0900, Masahiro Yamada wrote:
> Set the x bit to some scripts to make them directly executable.
> 
> Especially, scripts/checkdeclares.pl is not hooked by anyone.
> It should be executable since it is tedious to type
> 'perl scripts/checkdeclares.pl'.
> 
> The original patch [1] set the x bit properly, but it was lost when
> it was merged as commit 21917bded72c ("scripts: a new script for
> checking duplicate struct declaration").
> 
> [1] https://lore.kernel.org/lkml/20210401110943.1010796-1-wanjiabing@xxxxxxxx/
> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
> 
>  scripts/checkdeclares.pl               | 0
>  scripts/gcc-plugins/gen-random-seed.sh | 0
>  scripts/syscallnr.sh                   | 0
>  scripts/xen-hypercalls.sh              | 0
>  4 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 scripts/checkdeclares.pl
>  mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh
>  mode change 100644 => 100755 scripts/syscallnr.sh
>  mode change 100644 => 100755 scripts/xen-hypercalls.sh

Please no, as other tools (i.e. patch), can not set mode bits, and some
people still rely on patch in places.

If these need to be called by other parts of the build, we should
execute them properly, not rely on the mode settings.

thanks,

greg k-h