RE: [PATCH] gpio: mpc8xxx: Add ACPI support

[Ran Wang]

Hi Michael, Bartosz,

On Sunday, March 14, 2021 8:11 AM, Michael Walle wrote:
> 
> Am 2021-03-12 12:07, schrieb Bartosz Golaszewski:
> > On Fri, Mar 12, 2021 at 7:51 AM Ran Wang <ran.wang_1@xxxxxxx> wrote:
> >>
> >> Current implementation only supports DT, now add ACPI support.
> >>
> >> Note that compared to device of 'fsl,qoriq-gpio', LS1028A and
> >> LS1088A's GPIO have no extra programming, so simplify related
> >> checking.
> >>
> >> Signed-off-by: Ran Wang <ran.wang_1@xxxxxxx>
> >> ---
> >>  drivers/gpio/gpio-mpc8xxx.c | 50
> >> +++++++++++++++++++++++++++----------
> >>  1 file changed, 37 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/drivers/gpio/gpio-mpc8xxx.c
> >> b/drivers/gpio/gpio-mpc8xxx.c index 6dfca83bcd90..de5b7e17cde3 100644
> >> --- a/drivers/gpio/gpio-mpc8xxx.c
> >> +++ b/drivers/gpio/gpio-mpc8xxx.c
> >> @@ -9,6 +9,7 @@
> >>   * kind, whether express or implied.
> >>   */
> >>
> >> +#include <linux/acpi.h>
> >>  #include <linux/kernel.h>
> >>  #include <linux/init.h>
> >>  #include <linux/spinlock.h>
> >> @@ -292,8 +293,6 @@ static const struct of_device_id
> >> mpc8xxx_gpio_ids[] = {
> >>         { .compatible = "fsl,mpc5121-gpio", .data =
> >> &mpc512x_gpio_devtype, },
> >>         { .compatible = "fsl,mpc5125-gpio", .data =
> >> &mpc5125_gpio_devtype, },
> >>         { .compatible = "fsl,pq3-gpio",     },
> >> -       { .compatible = "fsl,ls1028a-gpio", },
> >> -       { .compatible = "fsl,ls1088a-gpio", },
> >
> > Why are you removing support for those?
> 
> I guess because it doesn't matter because usually
>   compatible = "fsl,ls1028a-gpio", "fsl,qoriq-gpio"; is used.

Yes,

>But I just had a look at the dt binding and it doesn't mandate it. So please keep it.

For now, strictly speaking, QorIQ pressors belong to Power Architecture
and Layerscape processor (LS1012A, LS1021A, LS1043A, LS1046A, LS1088A,
LS2088A, LX2160A, etc) belong to Arm Architecture

Although they are integrated the same GPIO controller IP with
minor difference (endian perspective), it would be find to use
SoC specific compatible + "qoriq-gpio" to make it work for all
Layerscape platforms (with "little-endian" accordingly).

But for mpc8xxx_gpio_ids, I think it would not be necessary
to list all LS/LX compatible strings. what do you say?

Regards,
Ran

> -michael
> 
> >
> > Bart
> >