Re: [PATCH] gpio: mpc8xxx: Add ACPI support

From: kernel test robot
Date: Fri Mar 12 2021 - 20:06:13 EST

Next message:
Previous message:
In reply to:
Next in thread:
Messages sorted by:
Hi Ran,

I love your patch! Perhaps something
[auto build test WARNING on gpio/for-next] [also build test WARNING on v5.12-rc2 [If your patch is applied to the And when submitting patch, we suggest .config.gz Description: application/gzipSaleem, Shiraz: "RE: RE: [PATCH] infiniband/i40iw: Fix a use after free in i40iw_cm_event_handler" Andrew Lunn: "Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver" Ran Wang: "RE: [PATCH] gpio: mpc8xxx: Add ACPI support" Andy Shevchenko: "Re: [PATCH] gpio: mpc8xxx: Add ACPI support" href="date.html#07797">[ date ] [ thread ] [ subject ] [ author ] to improve: next-20210312] wrong git tree, kindly drop us a note. to use '--base' as documented in om/docs/git-format-patch">https://git-scm.com/docs/git-format-patch] ithub.com/0day-ci/linux/commits/Ran-Wang/gpio-mpc8xxx-Add-ACPI-support/20210312-145412">https://github.com/0day-ci/linux/commits/Ran-Wang/gpio-mpc8xxx-Add-ACPI-support/20210312-145412 it.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git">https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next (attached as .config) 9.3.0 following tag as appropriate xxxxxx> error: uninitialized symbol 'devtype'. xx.c Anatolij Gustschin 2010-08-09 299 Ricardo Ribalda 2015-01-18 300 static int mpc8xxx_probe(struct platform_device *pdev) Peter Korsgaard 2008-09-23 301 { Ricardo Ribalda 2015-01-18 302 struct device_node *np = pdev->dev.of_node; Peter Korsgaard 2008-09-23 303 struct mpc8xxx_gpio_chip *mpc8xxx_gc; Peter Korsgaard 2008-09-23 304 struct gpio_chip *gc; Ran Wang 2021-03-12 305 const struct mpc8xxx_gpio_devtype *devtype; Ran Wang 2021-03-12 306 const struct acpi_device_id *acpi_id; Peter Korsgaard 2008-09-23 307 int ret; Peter Korsgaard 2008-09-23 308 Ran Wang 2021-03-12 309 if (pdev->dev.of_node) { Ran Wang 2021-03-12 310 devtype = of_device_get_match_data(&pdev->dev); Ran Wang 2021-03-12 311 } else { Ran Wang 2021-03-12 312 acpi_id = acpi_match_device(pdev->dev.driver->acpi_match_table, Ran Wang 2021-03-12 313 &pdev->dev); Ran Wang 2021-03-12 314 if (acpi_id) Ran Wang 2021-03-12 315 devtype = (struct mpc8xxx_gpio_devtype *) acpi_id->driver_data; Ran Wang 2021-03-12 316 } Ran Wang 2021-03-12 317 Ricardo Ribalda 2015-01-18 318 mpc8xxx_gc = devm_kzalloc(&pdev->dev, sizeof(*mpc8xxx_gc), GFP_KERNEL); Ricardo Ribalda 2015-01-18 319 if (!mpc8xxx_gc) Ricardo Ribalda 2015-01-18 320 return -ENOMEM; Peter Korsgaard 2008-09-23 321 Ricardo Ribalda 2015-01-18 322 platform_set_drvdata(pdev, mpc8xxx_gc); Ricardo Ribalda 2015-01-18 323 Alexander Stein 2015-07-21 324 raw_spin_lock_init(&mpc8xxx_gc->lock); Peter Korsgaard 2008-09-23 325 Ran Wang 2021-03-12 326 mpc8xxx_gc->regs = devm_platform_ioremap_resource(pdev, 0); Liu Gang 2016-02-03 327 if (!mpc8xxx_gc->regs) Liu Gang 2016-02-03 328 return -ENOMEM; Liu Gang 2016-02-03 329 Liu Gang 2016-02-03 330 gc = &mpc8xxx_gc->gc; Johnson CH Chen (陳昭勳 2019-11-26 331) gc->parent = &pdev->dev; Liu Gang 2016-02-03 332 Ran Wang 2021-03-12 333 if (device_property_read_bool(&pdev->dev, "little-endian")) { Liu Gang 2016-02-03 334 ret = bgpio_init(gc, &pdev->dev, 4, Liu Gang 2016-02-03 335 mpc8xxx_gc->regs + GPIO_DAT, Liu Gang 2016-02-03 336 NULL, NULL, Liu Gang 2016-02-03 337 mpc8xxx_gc->regs + GPIO_DIR, NULL, Liu Gang 2016-02-03 338 BGPIOF_BIG_ENDIAN); Liu Gang 2016-02-03 339 if (ret) Liu Gang 2016-02-03 340 goto err; Liu Gang 2016-02-03 341 dev_dbg(&pdev->dev, "GPIO registers are LITTLE endian\n"); Liu Gang 2016-02-03 342 } else { Liu Gang 2016-02-03 343 ret = bgpio_init(gc, &pdev->dev, 4, Liu Gang 2016-02-03 344 mpc8xxx_gc->regs + GPIO_DAT, Liu Gang 2016-02-03 345 NULL, NULL, Liu Gang 2016-02-03 346 mpc8xxx_gc->regs + GPIO_DIR, NULL, Liu Gang 2016-02-03 347 BGPIOF_BIG_ENDIAN Liu Gang 2016-02-03 348 | BGPIOF_BIG_ENDIAN_BYTE_ORDER); Liu Gang 2016-02-03 349 if (ret) Liu Gang 2016-02-03 350 goto err; Liu Gang 2016-02-03 351 dev_dbg(&pdev->dev, "GPIO registers are BIG endian\n"); Liu Gang 2016-02-03 352 } Peter Korsgaard 2008-09-23 353 Axel Lin 2016-02-22 354 mpc8xxx_gc->direction_output = gc->direction_output; Uwe Kleine-König 2015-07-16 355 Uwe Kleine-König 2015-07-16 @356 if (!devtype) Uwe Kleine-König 2015-07-16 357 devtype = &mpc8xxx_gpio_devtype_default; Uwe Kleine-König 2015-07-16 358 Uwe Kleine-König 2015-07-16 359 /* Uwe Kleine-König 2015-07-16 360 * It's assumed that only a single type of gpio controller is available Uwe Kleine-König 2015-07-16 361 * on the current machine, so overwriting global data is fine. Uwe Kleine-König 2015-07-16 362 */ Vladimir Oltean 2019-11-15 363 if (devtype->irq_set_type) Uwe Kleine-König 2015-07-16 364 mpc8xxx_irq_chip.irq_set_type = devtype->irq_set_type; Uwe Kleine-König 2015-07-16 365 Axel Lin 2016-02-22 366 if (devtype->gpio_dir_out) Axel Lin 2016-02-22 367 gc->direction_output = devtype->gpio_dir_out; Axel Lin 2016-02-22 368 if (devtype->gpio_get) Axel Lin 2016-02-22 369 gc->get = devtype->gpio_get; Axel Lin 2016-02-22 370 Peter Korsgaard 2010-01-07 371 gc->to_irq = mpc8xxx_gpio_to_irq; Peter Korsgaard 2008-09-23 372 Michael Walle 2020-09-30 373 /* Michael Walle 2020-09-30 374 * The GPIO Input Buffer Enable register(GPIO_IBE) is used to control Michael Walle 2020-09-30 375 * the input enable of each individual GPIO port. When an individual Michael Walle 2020-09-30 376 * GPIO port’s direction is set to input (GPIO_GPDIR[DRn=0]), the Michael Walle 2020-09-30 377 * associated input enable must be set (GPIOxGPIE[IEn]=1) to propagate Michael Walle 2020-09-30 378 * the port value to the GPIO Data Register. Michael Walle 2020-09-30 379 */ Ran Wang 2021-03-12 380 if (pdev->dev.of_node) { Ran Wang 2021-03-12 381 if (of_device_is_compatible(np, "fsl,qoriq-gpio")) Russell King 2019-11-19 382 gc->write_reg(mpc8xxx_gc->regs + GPIO_IBE, 0xffffffff); Ran Wang 2021-03-12 383 } else { Ran Wang 2021-03-12 384 if (acpi_match_device(pdev->dev.driver->acpi_match_table, Ran Wang 2021-03-12 385 &pdev->dev)) Ran Wang 2021-03-12 386 gc->write_reg(mpc8xxx_gc->regs + GPIO_IBE, 0xffffffff); Ran Wang 2021-03-12 387 } Russell King 2019-11-19 388 Liu Gang 2016-02-03 389 ret = gpiochip_add_data(gc, mpc8xxx_gc); Liu Gang 2016-02-03 390 if (ret) { Rob Herring 2017-07-18 391 pr_err("%pOF: GPIO chip registration failed with status %d\n", Rob Herring 2017-07-18 392 np, ret); Liu Gang 2016-02-03 393 goto err; Liu Gang 2016-02-03 394 } Peter Korsgaard 2008-09-23 395 Ran Wang 2021-03-12 396 mpc8xxx_gc->irqn = platform_get_irq(pdev, 0); Liu Gang 2016-02-03 397 if (!mpc8xxx_gc->irqn) Ricardo Ribalda 2015-01-18 398 return 0; Peter Korsgaard 2010-01-07 399 Ran Wang 2021-03-12 400 mpc8xxx_gc->irq = irq_domain_create_linear(dev_fwnode(&pdev->dev), Ran Wang 2021-03-12 401 MPC8XXX_GPIO_PINS, Ran Wang 2021-03-12 402 &mpc8xxx_gpio_irq_ops, Ran Wang 2021-03-12 403 mpc8xxx_gc); Ran Wang 2021-03-12 404 Peter Korsgaard 2010-01-07 405 if (!mpc8xxx_gc->irq) Ricardo Ribalda 2015-01-18 406 return 0; Peter Korsgaard 2010-01-07 407 Peter Korsgaard 2010-01-07 408 /* ack and mask all irqs */ Axel Lin 2016-02-22 409 gc->write_reg(mpc8xxx_gc->regs + GPIO_IER, 0xffffffff); Axel Lin 2016-02-22 410 gc->write_reg(mpc8xxx_gc->regs + GPIO_IMR, 0); Peter Korsgaard 2010-01-07 411 Song Hui 2019-10-11 412 ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn, Song Hui 2019-10-11 413 mpc8xxx_gpio_irq_cascade, Song Hui 2020-06-11 414 IRQF_SHARED, "gpio-cascade", Song Hui 2019-10-11 415 mpc8xxx_gc); Song Hui 2019-10-11 416 if (ret) { Song Hui 2019-10-11 417 dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d), ret = %d\n", Song Hui 2019-10-11 418 np->full_name, mpc8xxx_gc->irqn, ret); Song Hui 2019-10-11 419 goto err; Song Hui 2019-10-11 420 } Song Hui 2019-10-11 421 Ricardo Ribalda 2015-01-18 422 return 0; Liu Gang 2016-02-03 423 err: Liu Gang 2016-02-03 424 iounmap(mpc8xxx_gc->regs); Liu Gang 2016-02-03 425 return ret; Ricardo Ribalda 2015-01-18 426 } Ricardo Ribalda 2015-01-18 427 Corporation org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
- Next message: Saleem, Shiraz: "RE: RE: [PATCH] infiniband/i40iw: Fix a use after free in i40iw_cm_event_handler"
- Previous message: Andrew Lunn: "Re: [PATCH 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver"
- In reply to: Ran Wang: "RE: [PATCH] gpio: mpc8xxx: Add ACPI support"
- Next in thread: Andy Shevchenko: "Re: [PATCH] gpio: mpc8xxx: Add ACPI support"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]