Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.

From: Dan Carpenter
Date: Tue Mar 02 2021 - 17:55:06 EST


On Tue, Mar 02, 2021 at 07:28:05PM +0300, Dan Carpenter wrote:
> On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote:
> > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> >
> > > New smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
> > >
> > > Old smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'.
> >
> > I don't think these are real problems, but maybe there is some way to explicitly
> > express that so that smatch knows as well?
>
> They will call syzbot warning at runtime as well. Syzbot complains
> about the read, and not that the value is important for flow analysis.

s/flow analysis/flow control/... Syzbot doesn't care if the
uninitialized value affects runtime.

regards,
dan carpenter