Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.

From: Bjorn Andersson
Date: Tue Mar 02 2021 - 15:25:01 EST


On Tue 02 Mar 09:47 CST 2021, Linus Walleij wrote:

> On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> > New smatch warnings:
> > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
> >
> > Old smatch warnings:
> > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'.
>
> I don't think these are real problems, but maybe there is some way to explicitly
> express that so that smatch knows as well?
>

Perhaps I'm reading it wrong, but wouldn't a state that doesn't specify
drive-strength or bias cause these properties to be written out as some
undefined/uninitialized value? (I.e. isn't the report correct?)

Regards,
Bjorn