Re: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

From: Pavel Machek
Date: Wed Feb 03 2021 - 12:27:04 EST


Hi!

> > Yes, sounds reasonable. Could we get default intensity of 100% on all
> > channels if nothing else is specified?
> >
> > Or maybe simply "if intensity is not specified, start with 100%, and
> > use explicit =0 if other color is expected".
> >
> Mh, if someone is already using the led driver and updates to a newer kernel
> we would then turn on all leds per default to the maximum intensity during boot
> until they are set the way they should be from userspace. I don't know if this
> is what we want? If yes, sure, we could set them to maximum per
> default.

Not really. If they don't have trigger configured, nothing will happen.

> Also if we want to use Percentage Values (%) for setting the intensity
> I think this should also be done for the userspace interfaces and
> not only from DT.

We don't want to use percentages in the API (but let me still use
percentages in discussion).

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature