RE: [PATCH] misc: rtsx: modify rts522a init flow

[吳昊澄 Ricky]

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Sent: Tuesday, February 2, 2021 8:28 PM
> To: 吳昊澄 Ricky <ricky_wu@xxxxxxxxxxx>
> Cc: arnd@xxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; yuehaibing@xxxxxxxxxx;
> ulf.hansson@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> stable@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] misc: rtsx: modify rts522a init flow
> 
> The subject line could be more descriptive.  All patches modify something, so
> the only real information it contains is "rts522a" and "init".  Maybe it could
> say something about powering off OCP (whatever that is) when no memory
> card is present.
> 

Ok, I will update the subject line at V2 
"misc: rtsx: init of rts522a add power off OCP when no card is present"

> On Tue, Feb 02, 2021 at 06:56:41PM +0800, ricky_wu@xxxxxxxxxxx wrote:
> > From: Ricky Wu <ricky_wu@xxxxxxxxxxx>
> >
> > Power down OCP for power consumption
> > when card is not exist at init_hw()
> 
> I assume "card is not exist" means "no SD/MMC card is present".
> 

Right, it's that means, I will modify this description at V2

> Why do you only do this for 5227?  "card_exist" seems to be a generic
> concept (it's in struct rtsx_pcr and set by the generic rtsx_pci_init_hw()).
> Could/should this be done for other card readers as well?
> 

Only rts522a need to do this, other card readers can do HW auto power down

> > Cc: stable@xxxxxxxxxxxxxxx
> 
> Per https://www.kernel.org/doc/html/v5.10/process/stable-kernel-rules.html
> (option 1) this is sufficient.  You should not include stable@xxxxxxxxxx in the
> cc: list above.
> 

I am not very clear, I want this patch to Stable tree, so I added this Tag(Cc: stable@xxxxxxxxxxxxxxx)
If I remove this Tag, it means this patch not go to Stable Tree?

Ricky

> > Signed-off-by: Ricky Wu <ricky_wu@xxxxxxxxxxx>
> > ---
> >  drivers/misc/cardreader/rts5227.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/misc/cardreader/rts5227.c
> > b/drivers/misc/cardreader/rts5227.c
> > index 8859011672cb..8200af22b529 100644
> > --- a/drivers/misc/cardreader/rts5227.c
> > +++ b/drivers/misc/cardreader/rts5227.c
> > @@ -398,6 +398,11 @@ static int rts522a_extra_init_hw(struct rtsx_pcr
> > *pcr)  {
> >  	rts5227_extra_init_hw(pcr);
> >
> > +	/* Power down OCP for power consumption */
> > +	if (!pcr->card_exist)
> > +		rtsx_pci_write_register(pcr, FPDCTL, OC_POWER_DOWN,
> > +				OC_POWER_DOWN);
> > +
> >  	rtsx_pci_write_register(pcr, FUNC_FORCE_CTL,
> FUNC_FORCE_UPME_XMT_DBG,
> >  		FUNC_FORCE_UPME_XMT_DBG);
> >  	rtsx_pci_write_register(pcr, PCLK_CTL, 0x04, 0x04);
> > --
> > 2.17.1
> >
> 
> ------Please consider the environment before printing this e-mail.