Re: [PATCH] iommu/io-pgtalbe-arm: Remove "iopte_type(pte, l)" extra parameter "l"

[Kunkun Jiang]

Hi Will,

On 2020/12/7 18:24, Will Deacon wrote:
> On Mon, Dec 07, 2020 at 04:14:04PM +0800, Kunkun Jiang wrote:
> > Knowing from the code, the macro "iopte_type(pte, l)" doesn't use the
> > parameter "l" (level). So we'd better to remove it.
> >
> > Fixes: e1d3c0fd701df(iommu: add ARM LPAE page table allocator)
> > Signed-off-by: Kunkun Jiang <jiangkunkun@xxxxxxxxxx>
> > ---
> >   drivers/iommu/io-pgtable-arm.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
> > index a7a9bc08dcd1..925ae2b713d6 100644
> > --- a/drivers/iommu/io-pgtable-arm.c
> > +++ b/drivers/iommu/io-pgtable-arm.c
> > @@ -130,7 +130,7 @@
> >   /* IOPTE accessors */
> >   #define iopte_deref(pte,d) __va(iopte_to_paddr(pte, d))
> >   
> > -#define iopte_type(pte,l)					\
> > +#define iopte_type(pte)					\
> >   	(((pte) >> ARM_LPAE_PTE_TYPE_SHIFT) & ARM_LPAE_PTE_TYPE_MASK)
> Shouldn't we update all the users of the macro too?
>
> Will
> .

Sorry for my carelessness.  :(

I have resent it.


Thanks,

Kunkun Jiang