Re: [patch 3/3] tick: Annotate tick_do_timer_cpu data races

From: Peter Zijlstra
Date: Mon Dec 07 2020 - 07:11:14 EST


On Sun, Dec 06, 2020 at 10:12:56PM +0100, Thomas Gleixner wrote:
> + if (data_race(tick_do_timer_cpu) == TICK_DO_TIMER_BOOT) {

I prefer the form:

if (data_race(tick_do_timer_cpu == TICK_DO_TIMER_BOOT)) {

But there doesn't yet seem to be sufficient data_race() usage in the
kernel to see which of the forms is preferred. Do we want to bike-shed
this now and document the outcome somewhere?