Re: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT()

From: Arnd Bergmann
Date: Fri Jun 26 2020 - 10:37:59 EST


On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> lkdtm_DOUBLE_FAULT() already has internal logic to handle
> !CONFIG_X86_32. Compiling out the prototype actually prevents
> that logic from being useful.
>
> Fixes the following W=1 warning:
>
> drivers/misc/lkdtm/bugs.c: At top level:
> drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for âlkdtm_DOUBLE_FAULTâ [-Wmissing-prototypes]
> 420 | void lkdtm_DOUBLE_FAULT(void)
> | ^~~~~~~~~~~~~~~~~~
>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>