Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

From: Gerhard Wiesinger
Date: Sat Jun 20 2020 - 15:40:30 EST

Next message: kernel test robot: "drivers/gpu/drm/i915/gt/intel_workarounds.c:1082:20: error: function 'is_nonpriv_flags_valid' is not needed and will not be emitted"
Previous message: Matthew Wilcox: "Re: [RFC] Bypass filesystems for reading cached pages"
In reply to: Florian Fainelli: "Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA"
Next in thread: Florian Fainelli: "Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello Florian,

On 20.06.2020 21:13, Florian Fainelli wrote:

Hi,

On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote:
Can you share your network configuration again with me?

Find the network config below.

# OK: Last good known version (booting that version is also ok)
Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
armv7l armv7l armv7l GNU/Linux

OK, I suspect what has changed is this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab

which, if I remember your configuration correctly means that you now
have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces
can now run a proper networking stack unlike before where you had to do
this via the DSA master network device (eth0). This also means that you
should run your DHCP server/client on the bridge master network device now.

Yes, config should be a proper DSA config, see also below. IP config is only on brlan and brwan.

Do the changes need a config change?
e.g. net: dsa: b53: Ensure the default VID is untagged
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/dsa/b53?id=d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6

Thnx.

Ciao,
Gerhard

Config:

brctl show
bridge nameÂÂÂÂ bridge idÂÂÂÂÂÂÂÂÂÂÂÂÂÂ STP enabledÂÂÂÂ interfaces
brlanÂÂÂÂÂÂÂÂÂÂ 8000.AAAAAAAAAAAAÂÂÂÂÂÂ noÂÂÂÂÂÂÂÂÂÂÂÂÂ lan.101
brlanswÂÂÂÂÂÂÂÂ 8000.BBBBBBBBBBBBÂÂÂÂÂÂ noÂÂÂÂÂÂÂÂÂÂÂÂÂ lan1
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ lan2
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ lan3
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ lan4
brwanÂÂÂÂÂÂÂÂÂÂ 8000.CCCCCCCCCCCCÂÂÂÂÂÂ noÂÂÂÂÂÂÂÂÂÂÂÂÂ wan.102
brwanswÂÂÂÂÂÂÂÂ 8000.DDDDDDDDDDDDÂÂÂÂÂÂ noÂÂÂÂÂÂÂÂÂÂÂÂÂ wan

================================================================================

= /etc/systemd/network/30-autogen-eth0.network
================================================================================
[Match]
Name=eth0

[Network]
VLAN=lan.101
VLAN=wan.102
================================================================================
= /etc/systemd/network/40-autogen-lan.101.netdev
================================================================================
[NetDev]
Name=lan.101
Kind=vlan

[VLAN]
Id=101
================================================================================
= /etc/systemd/network/40-autogen-wan.102.netdev
================================================================================
[NetDev]
Name=wan.102
Kind=vlan

[VLAN]
Id=102
================================================================================
= /etc/systemd/network/50-autogen-brlan.netdev
================================================================================
[NetDev]
Name=brlan
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=false
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brlansw.netdev
================================================================================
[NetDev]
Name=brlansw
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=true
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brwan.netdev
================================================================================
[NetDev]
Name=brwan
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=false
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brwansw.netdev
================================================================================
[NetDev]
Name=brwansw
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=true
STP=false
================================================================================
= /etc/systemd/network/60-autogen-brlan-lan.101.network
================================================================================
[Match]
Name=lan.101

[Network]
Bridge=brlan
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan1.network
================================================================================
[Match]
Name=lan1

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan2.network
================================================================================
[Match]
Name=lan2

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan3.network
================================================================================
[Match]
Name=lan3

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan4.network
================================================================================
[Match]
Name=lan4

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brwansw-wan.102.network
================================================================================
[Match]
Name=wan.102

[Network]
Bridge=brwansw
================================================================================
= /etc/systemd/network/60-autogen-brwansw-wan.network
================================================================================
[Match]
Name=wan

[Network]
Bridge=brwansw

[BridgeVLAN]
VLAN=102
EgressUntagged=102
PVID=102
================================================================================
= /etc/systemd/network/60-autogen-brwan-wan.102.network
================================================================================
[Match]
Name=wan.102

[Network]
Bridge=brwan
================================================================================
= /etc/systemd/network/61-autogen-brlan.network
================================================================================
[Match]
Name=brlan

[Network]
Address=192.168.39.2/24
Gateway=192.168.39.1
DNS=192.168.39.1
Domains=mydomain
================================================================================
= /etc/systemd/network/61-autogen-brwan.network
================================================================================
[Match]
Name=brwan

[Network]
Address=192.168.1.1/24

Next message: kernel test robot: "drivers/gpu/drm/i915/gt/intel_workarounds.c:1082:20: error: function 'is_nonpriv_flags_valid' is not needed and will not be emitted"
Previous message: Matthew Wilcox: "Re: [RFC] Bypass filesystems for reading cached pages"
In reply to: Florian Fainelli: "Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA"
Next in thread: Florian Fainelli: "Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]