Re: [PATCH v12 5/7] clk: Ingenic: Add CGU driver for X1830.

[Zhou Yanjie]

Hi Stephen,

å 2020/5/28 äå9:13, Stephen Boyd åé:
> Quoting Zhou Yanjie (2020-05-27 10:56:33)
> > diff --git a/drivers/clk/ingenic/x1830-cgu.c b/drivers/clk/ingenic/x1830-cgu.c
> > new file mode 100644
> > index 000000000000..29a637f4a2cc
> > --- /dev/null
> > +++ b/drivers/clk/ingenic/x1830-cgu.c
> > @@ -0,0 +1,443 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * X1830 SoC CGU driver
> > + * Copyright (c) 2019 \u5468\u7430\u6770 (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> > + */
> > +
> > +#include <linux/clk-provider.h>
> > +#include <linux/delay.h>
> Add linux/io.h here.


Sure.


> > +#include <linux/of.h>
> > +
> > +#include <dt-bindings/clock/x1830-cgu.h>
> > +
> > +#include "cgu.h"
> [...]
> > +               return;
> > +       }
> > +
> > +       ingenic_cgu_register_syscore_ops(cgu);
> > +}
> > +CLK_OF_DECLARE_DRIVER(x1830_cgu, "ingenic,x1830-cgu", x1830_cgu_init);
> Same question about why this is DECLARE_DRIVER.


CGU has some children devices, this is useful for probing children 
devices in the case where the device node is compatible with 
"simple-mfd" (see commit 03d570e1a4dc for a reference).

Thanks and best regards!