Re: [PATCH] [net-next] dsa: sja1105: dynamically allocate stats structure

From: Arnd Bergmann
Date: Tue May 05 2020 - 11:34:58 EST


On Tue, May 5, 2020 at 4:04 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > - rc = sja1105_port_status_get(priv, &status, port);
> > + rc = sja1105_port_status_get(priv, status, port);
> > if (rc < 0) {
> > dev_err(ds->dev, "Failed to read port %d counters: %d\n",
> > port, rc);
> > - return;
> > + goto out;;
>
> Hi Arnd
>
> I expect static checker people will drive by soon with a fix for the ;; :-)

I need to fix the patch up anyway, as it accidentally included an unrelated
change that fails to apply. Fixed now.

Arnd