Re: [PATCH] [net-next] dsa: sja1105: dynamically allocate stats structure

From: Andrew Lunn
Date: Tue May 05 2020 - 10:04:49 EST


> - rc = sja1105_port_status_get(priv, &status, port);
> + rc = sja1105_port_status_get(priv, status, port);
> if (rc < 0) {
> dev_err(ds->dev, "Failed to read port %d counters: %d\n",
> port, rc);
> - return;
> + goto out;;

Hi Arnd

I expect static checker people will drive by soon with a fix for the ;; :-)

Andrew