Re: [PATCH] mm: Use fallthrough;

From: Joe Perches
Date: Sat Mar 07 2020 - 22:20:53 EST


On Sun, 2020-03-08 at 12:16 +0900, Sergey Senozhatsky wrote:
> On (20/03/06 23:58), Joe Perches wrote:
> [..]
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -424,7 +424,7 @@ static void *zs_zpool_map(void *pool, unsigned long handle,
> > case ZPOOL_MM_WO:
> > zs_mm = ZS_MM_WO;
> > break;
> > - case ZPOOL_MM_RW: /* fall through */
> > + case ZPOOL_MM_RW:
> > default:
> > zs_mm = ZS_MM_RW;
> > break;
>
> Seems like missing fallthrough; for ZPOOL_MM_RW?

Consecutive case labels do not need an interleaving fallthrough